[U-Boot] [PATCH v2] ne2000: Convert to new net-multi model, fixes build of three boards

[Mike Frysinger]

On Thursday 20 October 2011 16:56:59 Bernhard Kaindl wrote:
> --- a/drivers/net/ne2000_base.c
> +++ b/drivers/net/ne2000_base.c
> 
> +	/*
> +	 * According to doc/README.enetaddr, drivers shall give priority
> +	 * to the MAC address value in the environment, so we do not read
> +	 * it from the prom or eeprom if it is specified in the environment.
> +	 */
> +	if (!eth_getenv_enetaddr("ethaddr", dev->enetaddr)) {
> +		/* If the MAC address is not in the environment, get it: */
> +		if (!get_prom(dev->enetaddr, nic.base)) /* get MAC from prom */
> +			dp83902a_init(dev->enetaddr);   /* fallback: seeprom */
> +		/* And write it into the environment otherwise eth_write_hwaddr
> +		 * returns -1 due to eth_getenv_enetaddr_by_index() failing,
> +		 * and this causes "Warning: failed to set MAC address", and
> +		 * cmd_bdinfo has no ethaddr value which it can show: */
> +		eth_setenv_enetaddr("ethaddr", dev->enetaddr);
> +	}

this env parsing doesn't belong here.  the net drivers only read dev-
>enetaddr.  can you post a patch to drop this ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111208/4cf587d4/attachment.pgp>