[U-Boot] [PATCH v2 1/4] mmc: Change board_mmc_getcd() signature.

[Thierry Reding]

* Marek Vasut wrote:
> By "signature" you mean signedness ?

No, I mean "signature" as synonymous to "function prototype".

[...]
> > -int board_mmc_getcd(u8 *absent, struct mmc *mmc)
> > +int board_mmc_getcd(struct mmc *mmc)
> >  {
> >  	struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
> >  	uint32_t cd = efika_mmc_cd();
> > 
> >  	if (cfg->esdhc_base == MMC_SDHC1_BASE_ADDR)
> > -		*absent = gpio_get_value(IOMUX_TO_GPIO(cd));
> > -	else
> > -		*absent = gpio_get_value(IOMUX_TO_GPIO(MX51_PIN_GPIO1_8));
> > +		return !gpio_get_value(IOMUX_TO_GPIO(cd));
> > 
> > -	return 0;
> > +	return !gpio_get_value(IOMUX_TO_GPIO(MX51_PIN_GPIO1_8));
> 
> int ret;
> 
> if (cfg->...)
>   ret = ...
> else
>   ret = ...
> 
> return ret;

That'll require an extra variable and will actually be longer. I don't see
any advantage in converting it.

> DTTO here please, also add spaces into the comment ... /* GPIO1_4 */

I was going to keep that as it was, but I guess since I'm already changing
the line I can as well clean it up.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111209/8a6f9bfd/attachment.pgp>