[U-Boot] [PATCH v2 1/6] reboard: Create reloc.h and include it where needed

[Simon Glass]

Hi,

On Sun, Dec 11, 2011 at 2:29 PM, Albert ARIBAUD
<albert.u.boot at aribaud.net> wrote:
> Hi Gream,
>
> Le 11/12/2011 22:45, Graeme Russ a écrit :
>
>
>> I think the point is that when we pull stuff out of common.h into,
>> say, foo.h then only include foo.h where the functionality moved into
>> foo.h is _currently_ used.
>>
>> It looks like you've pulled out the functions definitions into reloc.h
>> then included reloc.h everywhere (including common.h). Better would be
>> to moved the definitions to reloc.h, do not include reloc.h in
>> common.h and include reloc.h only where it is strictly needed right
>> now - Add #include<reloc.h>  to each arch file as and when it is
>> needed
>
>
> Thanks Greame. This is indeed what I meant.

OK I understand, and that was my intention with this patch. Other than
the mistake of leaving the #include in common.h where it is not now
needed, is this patch correct?

Regards,
Simon

>
>> Regards,
>>
>> Graeme
>
>
> Amicalement,
> --
> Albert.