[U-Boot] [PATCH v2 6/6] reboard: arm: Remove unused code in start.S

Simon Glass sjg at chromium.org
Mon Dec 12 06:09:22 CET 2011


Hi Albert,

On Sun, Dec 11, 2011 at 6:59 AM, Albert ARIBAUD
<albert.u.boot at aribaud.net> wrote:
> Hi Simon,
>
> Le 10/12/2011 20:16, Simon Glass a écrit :
>
>> Now that we are using the generic relocation framework, we don't need this
>> code.
>>
>> Note: Here we lose the ARM1176's enable_mmu code. This seems to duplicate
>> code already in U-Boot now. Can anyone comment on this?
>
>
> First thing would be for you to explain why it is removed when it is not
> related to relocation, I think.

Well the code is unique to that cpu, with no real justification as to
why only ARM1176 needs it. Also it is buried in the relocation code,
which is now becoming generic, so to keep it around we would need to
re-implement ic C code something that seems like a hack. Finally, we
already have a way of turning on the caches and MMU in ARM now, so it
seems superfluous.

Regards,
Simon

>
> Amicalement,
> --
> Albert.


More information about the U-Boot mailing list