[U-Boot] Subject: [PATCH 0/2] ** Add ext4 filesystem support inuboot **

[uma.shankar at samsung.com]

Hi Graeme,
Thanks for your inputs.

Actually, the first patch [PATCH 0/2] is the cover patch containing only the 
description about the changes in the subsequent patches. (This patch 
contains information on how to test ext4 implementation)

The other two patches [PATCH 1/2] and [PATCH 2/2] containing the code are 
properly aligned and tested using checkpatch.pl script.

I think we can ignore the indentation in the cover patch. Please share your 
comments.

Thanks & Regards,
Uma Shankar
--------------------------------------------------
From: "Graeme Russ" <graeme.russ at gmail.com>
Sent: Monday, December 12, 2011 4:42 PM
To: <uma.shankar at samsung.com>
Cc: <u-boot at lists.denx.de>; <iqbal.ams at samsung.com>; 
<a.manjunatha at samsung.com>; <goodguy.lee at samsung.com>; <wd at denx.de>
Subject: Re: [U-Boot] Subject: [PATCH 0/2] ** Add ext4 filesystem support 
inuboot **

> Hi Uma,
>
> On 12/12/11 21:37, uma.shankar at samsung.com wrote:
>> Hi All,
>> We at Samsung have implemented ext4 file system support in uboot. Please
>> review the subsequent patches.
>>
>> Thanks & Regards,
>> Uma Shankar
>> Manjunatha C Achar
>>
>>
>> From: Uma Shankar <uma.shankar at samsung.com>
>> Date: Mon, 12 Dec 2011 12:01:23 +0530
>> Subject: [PATCH 0/2] *** Add ext4 filesystem support in uboot ***
>>
>> ***
>> This patch series adds support for ext4 ls,load and write features in 
>> uboot
>> Journaling is supported for write feature.
>>
>> To Enable EXT4 commands, modify the board specific config file with
>> #define CONFIG_CMD_EXT2 1
>> #define CONFIG_CMD_EXT4 1
>> Steps to test:
>>
>> 1. After applying the patch, ext4 specific commands can be seen
>>   in the boot loader prompt using
>> UBOOT #help
>>
>> ext4load- load binary file from a Ext4 file system
>> ext4ls  - list files in a directory (default /)
>> ext4write- create a file in ext4 formatted partition
>>
>> 2. To list the files in ext4 formatted partition, execute
>> ext4ls <interface> <dev[:part]> [directory]
>> For example:
>> UBOOT #ext4ls mmc 0:5 /usr/lib
>>
>> 3. To read and load a file from an ext4 formatted partition to RAM, 
>> execute
>> ext4load <interface> <dev[:part]> [addr] [filename] [bytes]
>> For example:
>> UBOOT #ext4load mmc 2:2 0x30007fc0 uImage
>>
>> 4. To write a file to a ext4 formatted partition.
>> a) First load a file to RAM at a particular address for example 
>> 0x30007fc0.
>> Now execute ext4write command
>> ext4write <interface> <dev[:part]> [filename] [Address] [sizebytes]
>> For example:
>> UBOOT #ext4write mmc 2:2 /boot/uImage 0x30007fc0 6183120
>> (here 6183120 is the size of the file to be written)
>> Note: Absolute path is required for the file to be written
>>
>> ***
>>
>> Uma Shankar (2):
>>  ext4fs ls load support
>>  ext4fs write support
>
> I notice different coding styles in the two patches - In particular, the
> first patch uses spaces for indentation and the second (correctly) uses 
> tabs
>
> Can you please run the 'checkpatch' script (it in the root of the u-boot
> tree) on both and correct any errors and warnings
>
> Regards,
>
> Graeme
>>
>> Makefile               |    2 +-
>> common/Makefile        |    1 +
>> common/cmd_ext4.c      |  388 ++++++++++
>> fs/Makefile            |    1 +
>> fs/ext2/ext2fs.c       |  303 +--------
>> fs/ext4/Makefile       |   51 ++
>> fs/ext4/crc16.c        |   61 ++
>> fs/ext4/crc16.h        |   17 +
>> fs/ext4/ext4_common.c  | 1954 
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>> fs/ext4/ext4_common.h  |   61 ++
>> fs/ext4/ext4_journal.c |  657 ++++++++++++++++
>> fs/ext4/ext4_journal.h |  147 ++++
>> fs/ext4/ext4fs.c       | 1252 +++++++++++++++++++++++++++++++
>> include/ext2fs.h       |  177 +++++-
>> include/ext4fs.h       |  172 +++++
>> 15 files changed, 4937 insertions(+), 307 deletions(-)
>> create mode 100644 common/cmd_ext4.c
>> create mode 100644 fs/ext4/Makefile
>> create mode 100644 fs/ext4/crc16.c
>> create mode 100644 fs/ext4/crc16.h
>> create mode 100644 fs/ext4/ext4_common.c
>> create mode 100644 fs/ext4/ext4_common.h
>> create mode 100644 fs/ext4/ext4_journal.c
>> create mode 100644 fs/ext4/ext4_journal.h
>> create mode 100644 fs/ext4/ext4fs.c
>> create mode 100644 include/ext4fs.h
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>