[U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board

[Tom Rini]

On Mon, Dec 12, 2011 at 8:39 AM, Ilya Yanok <yanok at emcraft.com> wrote:
> Hi Igor,
>
> thanks for your comments.
>
> On 30.11.2011 12:21, Igor Grinberg wrote:
>>> +#if defined(CONFIG_GENERIC_MMC) && defined(CONFIG_OMAP_HSMMC) && \
>>> +    !defined(CONFIG_SPL_BUILD)
>>> +int board_mmc_init(bd_t *bis)
>>> +{
>>> +    omap_mmc_init(0);
>>> +    return 0;
>>
>> return omap_mmc_init(0);
>>
>> I would also define this function ("weak") in some common place,
>> so we will not need to copy/paste it all over the boards, but
>> of course, it is not a blocker and I don't request this from you.
>> Only if you want to... :-)
>
> Well, we can use cpu_mmc_init() for this. But what slot(s) should we
> initialized in this common function? First? All?

The problem we have here is that board_mmc_init and cpu_mmc_init are
already both weak and you can't replace one weak function with another
weak function (or if you can, you need to play linker games).  I had
given this a quick stab but not reported back since I hadn't finished
the rest of the related task (SPL and MMC support for am335x).

-- 
Tom