[U-Boot] [PATCH] fs/fat/fat.c: fix warning: 'part_size' defined but not used

Wolfgang Denk wd at denx.de
Tue Dec 13 12:03:35 CET 2011


Dear Anatolij Gustschin,

In message <20111213095358.5601b9ce at wker> you wrote:
> 
> The FAT write support as submitted and included seems to be broken.
> The removed variable is referenced in fs/fat/fat_write.c, but in
> fs/fat/fat.c it is declared as static. This issue didn't show up
> because no board config file in mainline defines CONFIG_FAT_WRITE.

It's not only that.  It appears that this code is also not hooked upo
to any command a user could call.  At least, I cannot see anything
like that in common/cmd_fat.c or so...

> @ Donggeun Kim
> Could you please submit a patch fixing this?

I guess this needs more fixing...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you own a machine, you are in turn owned by it,  and  spend  your
time serving it..."    - Marion Zimmer Bradley, _The Forbidden Tower_


More information about the U-Boot mailing list