[U-Boot] [PATCH 04/13] common/cmd_pxe.c: Fix compile warning

[Jason Hobbs]

On Fri, Dec 09, 2011 at 03:45:44PM -0500, Wolfgang Denk wrote:
> Dear Jason,
> 
> In message <20111209134819.GA26840 at jhobbs-laptop> you wrote:
> > 
> > >  	default:
> > >  		printf("Ignoring malformed menu command: %.*s\n",
> > >  				(int)(*c - s), s);
> > > +		err = -1;
> > 
> > err should either be set to 0 here, or initialized to 0 at the top of
> > the function. Setting it to -1 will cause the parser to give up rather
> > than just printing out the warning message. It doesn't have to give up,
> > and not giving up makes the parser more accommodating of pxelinux
> > commands that aren't supported in U-Boot.
> 
> You have way more experience with PXE than me, but if we runinto this
> case, doesn't that mean that the whole menu setup is severely broken,
> and continuing is more or less invoking random behaviour?

It only means that an unrecognized menu command was used. It could be
something aesthetic in nature, like a menu title command.

> 
> If you really want to see a 0 here, then please feel free to submit an
> updated / fixed patch.

Heiko Schocher ended up sending a patch to do this today, which I've
acked.

Thanks,

Jason