[U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

Tom Rini tom.rini at gmail.com
Tue Dec 13 19:54:39 CET 2011


On Tue, Dec 13, 2011 at 11:45 AM, Scott Wood <scottwood at freescale.com> wrote:
> On 12/13/2011 12:33 PM, Tom Rini wrote:
>> So, we have various characteristics of the NAND chip that need to be
>> described for SPL.  Today we do CONFIG_SYS_NAND... but they're
>> unchanged in every implementation and are calculated from other
>> per-board values.  So to avoid duplication in each config file, we
>> drop them from there and use them only locally #define calculate them
>> in the file that needs them.  Since they're still system specific
>> values, I had suggested calling them SYS_... but I wasn't sure what
>> the right namespace is.  I had a recollection that using CONFIG_
>> outside of config files was a bad idea.
>
> These symbols are not in a header file -- how about just plain ECCSTEPS
> and ECCTOTAL?

Works for me and Wolfgang (on IRC) so lets go there for a hopefully
last v4 (along with what Scott said in the other email)

-- 
Tom


More information about the U-Boot mailing list