[U-Boot] [PATCH 3/4] USB: ULPI: increase error case verbosity

Simon Glass sjg at chromium.org
Wed Dec 14 01:27:41 CET 2011


On Mon, Dec 12, 2011 at 2:08 AM, Igor Grinberg <grinberg at compulab.co.il> wrote:
> Add the argument value to the error message.
>
> Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>

Acked-by: Simon Glass <sjg at chromium.org>

(I do wonder if this should be debug() rather than printf(), but that's fine)

> ---
>  drivers/usb/ulpi/ulpi.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/ulpi/ulpi.c b/drivers/usb/ulpi/ulpi.c
> index f3f293f..6202227 100644
> --- a/drivers/usb/ulpi/ulpi.c
> +++ b/drivers/usb/ulpi/ulpi.c
> @@ -92,8 +92,8 @@ int ulpi_select_transceiver(u32 ulpi_viewport, unsigned speed)
>                tspeed = speed;
>                break;
>        default:
> -               printf("ULPI: %s: wrong transceiver speed specified, "
> -                       "falling back to full speed\n", __func__);
> +               printf("ULPI: %s: wrong transceiver speed specified: %u, "
> +                       "falling back to full speed\n", __func__, speed);
>        }
>
>        val = ulpi_read(ulpi_viewport, &ulpi->function_ctrl);
> @@ -140,8 +140,8 @@ int ulpi_opmode_sel(u32 ulpi_viewport, unsigned opmode)
>                topmode = opmode;
>                break;
>        default:
> -               printf("ULPI: %s: wrong OpMode specified, "
> -                       "falling back to OpMode Normal\n", __func__);
> +               printf("ULPI: %s: wrong OpMode specified: %u, "
> +                       "falling back to OpMode Normal\n", __func__, opmode);
>        }
>
>        val = ulpi_read(ulpi_viewport, &ulpi->function_ctrl);
> @@ -161,8 +161,8 @@ int ulpi_serial_mode_enable(u32 ulpi_viewport, unsigned smode)
>        case ULPI_IFACE_3_PIN_SERIAL_MODE:
>                break;
>        default:
> -               printf("ULPI: %s: unrecognized Serial Mode specified\n",
> -                       __func__);
> +               printf("ULPI: %s: unrecognized Serial Mode specified: %u\n",
> +                       __func__, smode);
>                return ULPI_ERROR;
>        }
>
> --
> 1.7.3.4
>


More information about the U-Boot mailing list