[U-Boot] [PATCH v6 4/6] arm, da850evm: Add an SPL for SPI boot

[Tom Rini]

On 12/14/2011 12:09 PM, Christian Riesch wrote:
> Hi,
> 
> On Wed, Dec 14, 2011 at 3:09 PM, Tom Rini <tom.rini at gmail.com
> <mailto:tom.rini at gmail.com>> wrote:
>> On Tue, Dec 13, 2011 at 11:33 PM, Christian Riesch
>> <christian.riesch at omicron.at <mailto:christian.riesch at omicron.at>> wrote:
>>> Hi,
>>>
>>> On Friday, December 9, 2011, Christian Riesch
> <christian.riesch at omicron.at <mailto:christian.riesch at omicron.at>>
>>> wrote:
>>>> Signed-off-by: Christian Riesch <christian.riesch at omicron.at
> <mailto:christian.riesch at omicron.at>>
>>>> Cc: Heiko Schocher <hs at denx.de <mailto:hs at denx.de>>
>>>> Cc: Sandeep Paulraj <s-paulraj at ti.com <mailto:s-paulraj at ti.com>>
>>>> Cc: Tom Rini <trini at ti.com <mailto:trini at ti.com>>
>>>> Cc: Sudhakar Rajashekhara <sudhakar.raj at ti.com
> <mailto:sudhakar.raj at ti.com>>
>>>> ---
>>>>  board/davinci/da8xxevm/da850evm.c     |    4 +-
>>>>  board/davinci/da8xxevm/u-boot-spl.lds |   73
> +++++++++++++++++++++++++++
>>>>  doc/README.davinci                    |    9 +++
>>>>  include/configs/da850evm.h            |   87
>>> +++++++++++++++++++++++++++++++++
>>>>  4 files changed, 172 insertions(+), 1 deletions(-)
>>>>  create mode 100644 board/davinci/da8xxevm/u-boot-spl.lds
>>>
>>> Thanks for merging this into ti/next, Tom!
>>>
>>> I'd like to submit a similar patch for the da850_am18xxevm board. Before
>>> commit 06194b6b65f701a9d6ef2d9b4123c4afe57d8783 both the da850evm and the
>>> da850_am18xxevm used the same configuration, and the differences
> introduced
>>> in the commit are rather small. Should I submit a patch that adds the
> same
>>> SPL configuration to the am18xx board config? Or should we create a
> header
>>> file that contains the common parts and include it in both da850evm.h and
>>> da850_am18xxevm.h? Or shall we use the Options column in boards.cfg?
>>
>> I'd like it if you submitted a patch for both boards.  On my TODO list
>> is seeing about cleaning up some of the config files for non-omap4/5
>> (which have a common.h file they start with) in 2012.03.
> 
> Ok, I'll try to provide a patch for da850_am18xxevm.h, but currently I
> can't get it running:
> 
> I applied the changes that I did in include/configs/da850evm.h before to
> da850_am18xxevm.h as well. I expected this to work on my board since the
> board I used to test the SPI flash SPL patchset for the da850evm was
> actually an AM1808 experimenter's kit.
> 
> Now my SPL reports:
> 
> SF: Unsupported manufacturer 20
> failed.
> 
> Manufacturer 0x20 seems to be ST and the main difference between
> da850evm.h and da850_am18xxevm.h is the missing #define
> CONFIG_SPI_FLASH_STMICRO in da850_am18xxevm.h.
> 
> So my question is: Which boards are supported by da850_am18xxevm.h? I
> thought that I probably have an old revision of the board, but I
> couldn't find anything regarding SPI flash in LogicPD's PCNs.

So, the da850evm is for the OMAP-L138 and da850_am18xxevm is for the
AM18xx EVM.  However, the config split was done, I believe, but folks on
the L138 side and might not have been tried fully on the am1808.  So
since you've got the AM1808 and can test it there, lets add the missing
SPI_FLASH define too.  I think my coworker that did a quick non-SPL
check of the code the other week also noted SPI wasn't supported.

-- 
Tom