[U-Boot] [PATCH] mx28evk: Add initial support for MX28EVK board

[Fabio Estevam]

Hi Marek,

On Wed, Dec 14, 2011 at 6:51 PM, Marek Vasut <marek.vasut at gmail.com> wrote:

>> +void imx_get_mac_from_fuse(char *mac)
>> +{
>> +     memset(mac, 0, 6);
>
> OCOTP code is no good for you?

It works fine, except that it only gets the correct MAC for FEC0:

Warning: FEC1 MAC addresses don't match:
Address in SROM is         00:04:9f:01:d2:94
Address in environment is  00:04:9f:01:d2:95

ethaddr=00:04:9F:01:D2:94
eth1addr=00:04:9F:01:D2:95

Also, I see that on m28evk this code is not being used because
CONFIG_M28_FEC_MAC_IN_OCOTP
is not defined.

I think we should move this function to common code. To avoid the dual
FEC MAC issue for now, I can also use a single FEC instead, as I
probably won't have time to investigate this during this year.

...
>> --- /dev/null
>> +++ b/board/freescale/mx28evk/u-boot.bd
>> @@ -0,0 +1,14 @@
>> +sources {
>> +     u_boot_spl="spl/u-boot-spl.bin";
>> +     u_boot="u-boot.bin";
>> +}
>> +
>> +section (0) {
>> +        load u_boot_spl > 0x0000;
>> +        load ivt (entry = 0x0014) > 0x8000;
>> +     hab call 0x8000;
>> +
>> +        load u_boot > 0x40000100;
>> +        load ivt (entry = 0x40000100) > 0x8000;
>> +     hab call 0x8000;
>
> Change the indent here to tabs please, similar patch is queued mainline for m28.

Ok

...
>> + * Extra Environments
>> + */
>> +#define CONFIG_EXTRA_ENV_SETTINGS \
>> +     "console_fsl=console=ttyAM0" \
>
> ttyAM? You sure?

Yes, FSL BSP uses ttyAM0. Mainline kernel uses ttyAMA0.

I left the mainline version as default.

Thanks,

Fabio Estevan