[U-Boot] [PATCH] sandbox: Add tap based networking

[Simon Glass]

Hi Mike,

On Tue, Dec 13, 2011 at 7:35 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Tuesday 13 December 2011 18:54:59 Simon Glass wrote:
>> On Sun, Dec 4, 2011 at 9:57 AM, Matthias Weisser wrote:
>> > --- a/arch/sandbox/cpu/os.c
>> > +++ b/arch/sandbox/cpu/os.c
>> > @@ -19,6 +19,7 @@
>> >  * MA 02111-1307 USA
>> >  */
>> >
>> > +#include <config.h>
>> >  #include <fcntl.h>
>> >  #include <stdlib.h>
>> >  #include <termios.h>
>> > @@ -30,6 +31,19 @@
>> >  #include <sys/mman.h>
>> >  #include <linux/types.h>
>> >
>> > +#ifdef CONFIG_NET_TAP
>>
>> I don't think we need this #ifdef
>
> i think it's fine.  the current code isn't too tied to Linux, but adding
> NET_TAP unconditionally would make it completely Linux specific ...
> -mike

OK that's fine.

Regards,
Simon