[U-Boot] [PATCH] OMAP3: Add Corscience Tricorder board

[Tom Rini]

On Thu, Dec 15, 2011 at 3:16 AM, Thomas Weber <weber at corscience.de> wrote:
> Tricorder is a board which is very similar to the Devkit8000. It
> is designed as a base platform for further medical devices.
>
> www.corscience.de/en/medical-engineering/products/multiparameter/mp10-board.html
[snip]
> +#if defined(CONFIG_GENERIC_MMC) && !(defined(CONFIG_SPL_BUILD))
> +int board_mmc_init(bd_t *bis)
> +{
> +       omap_mmc_init(0);
> +       return 0;
> +}
> +#endif

Just return omap_mmc_init(0) :)

[snip]
> +++ b/include/configs/tricorder.h
[snip]
> +/* DDR - I use Micron DDR */
> +#define CONFIG_OMAP3_MICRON_DDR

Unused

[snip]
> +/* TWL4030 */
> +#define CONFIG_TWL4030_POWER           1
> +#define CONFIG_TWL4030_LED             1

Do these need the '1' ?

> +/* Board NAND Info */
> +#define CONFIG_SYS_NO_FLASH            /* no NOR flash */
> +#define CONFIG_MTD_DEVICE              /* needed for mtdparts commands */
> +#define MTDIDS_DEFAULT                 "nand0=nand"
> +#define MTDPARTS_DEFAULT               "mtdparts=nand:" \
> +                                               "512k(u-boot-spl)," \
> +                                               "1920k(u-boot)," \
> +                                               "128k(u-boot-env)," \
> +                                               "4m(kernel)," \
> +                                               "-(fs)"

Curious, medical device but not using redundant env?  Or something
special hidden in those extra-large sizes?

[snip]
> +       "nandargs=" \
> +               "run commonargs; " \
> +               "setenv bootargs ${bootargs} " \
> +               "omapfb.mode=lcd:${lcdmode} " \
> +               "omapdss.def_disp=${defaultdisplay} " \
> +               "root=/dev/mtdblock4 " \
> +               "rootfstype=ubifs " \
> +               "${kernelopts}\0" \

Curious, this works too?  I'm used to the 'root=ubi0:rootfs rootwait'
or so syntax

[snip]
> +#define CONFIG_SYS_MAXARGS             128     /* max number of command args */

What?  I swear this is just for args passed to u-boot commands and
unrelated to args passed to the kernel via bootargs= so 16 or so is a
nice sane default.

[snip]
> +#define CONFIG_SYS_NAND_BAD_BLOCK_POS  0

NAND_LARGE_BADBLOCK_POS please.

-- 
Tom