[U-Boot] [PATCH 1/2] net/fm: check the old and new Fman microcode locations in NOR flash

[Kumar Gala]

On Dec 15, 2011, at 2:09 PM, Timur Tabi wrote:

> Kumar Gala wrote:
> 
>> I see no reason for this patch, if you're flashing a new u-boot flash
>> the microcode to the new address as well.  
> 
> This is useful for people who have not moved the microcode.  Are we going to ensure that everyone who updates U-Boot will also move their microcode to the new location?  We can always revert this patch after everyone has migrated, if that's really necessary.
> 
> You know as well as I do that if don't provide backwards compatibility, someone is going to break and won't know why.

Sure, but they'll get the message about invalid ucode.  It will be easy to debug.  At some point they're going to have to flash ucode to the new address.  I see no reason to delay that.

>> Don't we already have a
>> warning if we don't find the ucode at the expected address.
> 
> No.  The warning just says that microcode is invalid, not that that it's at the wrong address.  

Invalid is sufficient to say you need to check the ucode at the address its being attempted to be loaded from.

- k