[U-Boot] fsl_esdhc.c bug

[Graeme Russ]

Hi Jim

On Dec 17, 2011 1:11 AM, "Jim Lentz" <JLentz at zhone.com> wrote:
>
> All,
>
> There is a bug rendering SDCard support useless on Freescale esdhc
controller.
>
> File drivers/mmc/fsl_esdhc.c, function esdhc_pio_read_write
>
> *change: *
>
> struct fsl_esdhc *regs = mmc->priv;
>
> *to:*
>
> struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
> volatile struct fsl_esdhc *regs = (struct fsl_esdhc *)cfg->esdhc_base;

use of volatile is highly likely to be wrong

>
> How do I/we get this into the mainstream?

First read:

http://www.denx.de/wiki/U-Boot/CodingStyle

And:

http://www.denx.de/wiki/U-Boot/Patches

>
> I cloned the repository, and have it fixed. First time using git, and
trying to contribute to OpenSource too.

git format-patch and git send-email

Regards,

Graeme