[U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup

Mike Frysinger vapier at gentoo.org
Fri Dec 16 18:13:43 CET 2011


On Friday 16 December 2011 04:54:42 Marek Vasut wrote:
> > On Thursday 15 December 2011 08:26:41 Marek Vasut wrote:
> > > First of the CHECKPATCH series of patches with per-file checkpatch
> > > fixes.
> > > 
> > > This series fixes all files fpgadata.c, which contains PPC FPGA
> > > firmwares. There are no functional changes, only CHECKPATCH fixes.
> > 
> > i don't really see any point in touching the fpgadata.c files.  they're
> > clearly generated files and not meant to be read at all let alone
> > modified after the fact ...
> > 
> > of course, i'd wonder what created these in the first place, and apply
> > any style tastes to that tool and then regenerate the result ...
> 
> Well when the person updates these, he will hit a problem and fix his tool.

no he won't.  these files get clobbered and committed, not inline merged.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111216/32f69524/attachment.pgp>


More information about the U-Boot mailing list