[U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET

[Mike Frysinger]

On Friday 16 December 2011 13:49:15 Moffett, Kyle D wrote:
> On Dec 16, 2011, at 00:05, Mike Frysinger wrote:
> > On Thursday 15 December 2011 22:32:41 Kyle Moffett wrote:
> >> This new #define is set in config_cmd_defaults.h (which is automatically
> >> included on every board by "mkconfig"), but this allows boards to elect
> >> to omit the "reset" command if necessary with "#undef CONFIG_CMD_RESET".
> > 
> > NAK: doesn't seem to address the feedback i posted last time ...
> 
> Hmm, I thought I addressed these:
> >> --- a/include/config_cmd_defaults.h
> >> +++ b/include/config_cmd_defaults.h
> > 
> > updating these files is not sufficient and will break boards.  drop the
> > hunks to these files and update include/config_defaults.h instead.
> 
> The "mkconfig" program automatically includes both config_defaults.h and
> config_cmd_defaults.h, so this is sufficient to not break boards.

ah, you're right.  sorry about that.  i was thinking of "config_cmd_default.h" 
which is not the same as "config_cmd_defaults.h" ;).

> > would be a good time to split this into a dedicated common/cmd_reset.c,
> > we can also then fix cmd_boot.c to only build when CONFIG_CMD_GO is
> > enabled
> 
> The only references to CONFIG_CMD_GO are in config_cmd_defaults.h, README,
> and common/cmd_boot.c, there is nothing that ever turns it off, so perhaps
> the config symbol should just be removed?

i have some boards that turn it off
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111216/e9d926ce/attachment.pgp>