[U-Boot] [PATCH] net/eth: Don't issue warnings for offboard ethernet chips

[Wolfgang Denk]

Dear Kyle Moffett,

In message <1324001821-15337-1-git-send-email-Kyle.D.Moffett at boeing.com> you wrote:
> When using an offboard ethernet chip such as e1000, it is highly likely
> that the driver has already read a valid MAC address from the onboard
> EEPROM.  In that case, U-Boot should not issue a warning about the
> absence of an "eth*addr" value in the environment.

Yes, it should.  The rule is that then environment settings always
have precedence, and if they are missing or contain different data
than other sources for this inofmration, a waning shall be printed.


> A properly configured HWW-1U-1A board is fixed from this output:
> 
>   Net:   e1000: 00:50:93:81:ff:8a
>          e1000: 00:50:93:81:ff:8b
>          owt0, owt1, peer, e1000#0
>   Warning: failed to set MAC address
>   , e1000#1
>   Warning: failed to set MAC address
> 
> To this:
> 
>   Net:   e1000: 00:50:93:81:ff:8a
>          e1000: 00:50:93:81:ff:8b
>          owt0, owt1, peer, e1000#0, e1000#1

This is also not correct.  There should never be any printing of the
MAC addresses here.

The messages should be:

	Net:   owt0, owt1, peer, e1000#0, e1000#1

> Furthermore, the log messages should avoid screwing up the "Net:" output
> formatting provided by the calling code, EG:
> 
>   Net:   eth0, eth1 [could not set MAC: 00:50:93:81:ff:8a], eth2

No.  "could not set" is an error message, and deserves a separate
line.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"What terrible way to die."
"There are no good ways."
	-- Sulu and Kirk, "That Which Survives", stardate unknown