[U-Boot] [PATCH] km/common: add toolchain variable

Wolfgang Denk wd at denx.de
Sat Dec 17 21:49:08 CET 2011


Dear Holger Brunck,

In message <1323879110-8404-1-git-send-email-holger.brunck at keymile.com> you wrote:
> Add a variable "toolchain" and configure the rootpath
> for the nfsargs with this variable.
> 
> Signed-off-by: Holger Brunck <holger.brunck at keymile.com>
> cc: Wolfgang Denk <wd at denx.de>
> ---
>  board/keymile/scripts/README             |    2 +-
>  board/keymile/scripts/develop-common.txt |    3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/board/keymile/scripts/README b/board/keymile/scripts/README
> index 7fbcf74..dd935b2 100644
> --- a/board/keymile/scripts/README
> +++ b/board/keymile/scripts/README
> @@ -7,7 +7,7 @@ default environment must be parsed:
>  run develop : setup environment to configure for rootfs via nfs
>  run ramfs   : setup environment to configure for rootfs in ram
>  
> -Last change: 20.05.2011
> +Last change: 24.11.2011

Does this really make any sense?  Which date are you recording here/
When you (think) you last edited the file? When you applied the patch
to your local tree? When you submitted it for mainline? When it
actually got applied?

I recommend to get rid of this, and rather use git revision
information instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human mind  ordinarily  operates  at  only  ten  percent  of  its
capacity. The rest is overhead for the operating system.


More information about the U-Boot mailing list