[U-Boot] [PATCH] net: Fix arguments in tftpput command

[Simon Glass]

Hi Wolfgang,

On Sat, Dec 17, 2011 at 12:00 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
>
> In message <1324095888-22757-1-git-send-email-sjg at chromium.org> you wrote:
>> The switch to strict_strtoul() was not done correctly - this fixes
>> the compile error when CONFIG_CMD_TFTPPUT is active.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>  common/cmd_net.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/common/cmd_net.c b/common/cmd_net.c
>> index f89a24b..be7cc01 100644
>> --- a/common/cmd_net.c
>> +++ b/common/cmd_net.c
>> @@ -221,8 +221,8 @@ static int netboot_common(enum proto_t proto, cmd_tbl_t *cmdtp, int argc,
>>
>>  #ifdef CONFIG_CMD_TFTPPUT
>>       case 4:
>> -             save_addr = strict_strtoul(argv[1], NULL, 16);
>> -             save_size = strict_strtoul(argv[2], NULL, 16);
>> +             strict_strtoul(argv[1], 16, &save_addr);
>> +             strict_strtoul(argv[2], 16, &save_size);
>
> strict_strtoul() returns error codes.  We should not ignore these.

Er yes, I wondered about that. I will resubmit with a cmd_usage() in that case.

Regards,
Simon

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Vulcans believe peace should not depend on force.
>        -- Amanda, "Journey to Babel", stardate 3842.3