[U-Boot] [PATCH 02/16] arch/arm/lib/bootm.c: Optionally use existing atags

[Mike Frysinger]

On Saturday 17 December 2011 12:03:04 Pali Rohár wrote:
> +	s = getenv ("atagaddr");

no space before the "("

>  #if defined (CONFIG_SETUP_MEMORY_TAGS) || \
>      defined (CONFIG_CMDLINE_TAG) || \
>      defined (CONFIG_INITRD_TAG) || \
>      defined (CONFIG_SERIAL_TAG) || \
>      defined (CONFIG_REVISION_TAG)
> ...
> +#if defined (CONFIG_SETUP_MEMORY_TAGS) || \
> +    defined (CONFIG_CMDLINE_TAG) || \
> +    defined (CONFIG_INITRD_TAG) || \
> +    defined (CONFIG_SERIAL_TAG) || \
> +    defined (CONFIG_REVISION_TAG)

rather than duplicating the same list in multiple places, why not setup a 
local define in this file and then use that everywhere else.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111218/0af923bd/attachment.pgp>