[U-Boot] [PATCH] km/common: add toolchain variable

Wolfgang Denk wd at denx.de
Mon Dec 19 09:57:20 CET 2011


Dear Holger Brunck,

In message <4EEEF0D3.5040302 at keymile.com> you wrote:
> 
> >> +Last change: 24.11.2011
> > 
> > Does this really make any sense?  Which date are you recording here/
> > When you (think) you last edited the file? When you applied the patch
> > to your local tree? When you submitted it for mainline? When it
> > actually got applied?
> 
> What I want to record is to track the version of the scripts and this makes
> sense for me. In the end the scripts are copied into /tftpboot on each
> developers machine and is therefore not under git control. It is an easy
> indication wether the scripts are uptodate or not, without starting a diff tool
> and compare them with the latest git tree. Inside the git tree the information
> is useless, I agree.

You can insert such information when you export the files from git,
say by adding a line like:

	Last commit date: $Format:%H  %cD$

That would IMO make much more sense.

See what we do with "snapshot.commit" in U-Boot [see also the entry
in .git/info/attributes].

> > I recommend to get rid of this, and rather use git revision
> > information instead.
> > 
> 
> I would like to keep this, because git does not easily help here.

Maybe it does - see above.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Committee, n.:  A group of men who individually can do nothing but as
a group decide that nothing can be done.                 - Fred Allen


More information about the U-Boot mailing list