[U-Boot] [PATCH v1 1/2] tpm: Rename generic_lpc_tpm to tpm_tis_lpc

Wolfgang Denk wd at denx.de
Mon Dec 19 12:38:08 CET 2011


Dear Che-liang Chiou,

In message <CANJuy2JQ3nf2MJpxRS-8JgKsiV1ZG2sfcNqDMrKSaqpifuPGHg at mail.gmail.com> you wrote:
>
> > Should we not rather remove all this dead code again?
> >
> > Until today there are no users for this code in mainline, and no
> > patches have been submitted that intend to use it.
> 
> Chrome/Chromium OS uses TPM for its secure boot. So I would say it is
> quite a lot of usage on the critical path of booting.

I do not see any such code in mainline.  So for mainline, this is just
dead code, i. e. it adds maintenance efforts without benefit for any
mainline users.

> The code that uses TPM did not send to the mainline because the
> mainline did not have a TPM driver until very recently.

Well, the patche shave been submitted long time ago, so I would have
expected to see such code soon after.  But so far, nothign happened.

Now you are trying to add even more code, with still no users in
sight.

> And, I am still figuring out how to submit the TPM user code. I guess
> it would be better to organize it in a command-line toolkit so that it
> can be interleaved in between other commands. What do you think?

I don't understand what you mean.  Didn't you just write there was
code ready to be submitted?  So that code is not ready and not
intended for mainline?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never ascribe to malice that which can  adequately  be  explained  by
stupidity.


More information about the U-Boot mailing list