[U-Boot] [PATCH v3 1/2] net: add Calxeda xgmac driver

[Wolfgang Denk]

Dear Rob Herring,

In message <1323983750-3399-1-git-send-email-robherring2 at gmail.com> you wrote:
> From: Rob Herring <rob.herring at calxeda.com>
> 
> This adds ethernet driver for Calxeda xgmac found on Highbank SOC.
> 
> Signed-off-by: Rob Herring <rob.herring at calxeda.com>
> ---
> v3:
> - whitespace fixes
> - move reset to .init function
> - fix calxedaxgmac_initialize return values
> - fix 2 build warnings
> 
> v2:
> -Convert register base plus offset to struct
> -drop ethaddr env setting
> -drop valid mac address check
> 
>  README                     |    3 +
>  drivers/net/Makefile       |    1 +
>  drivers/net/calxedaxgmac.c |  553 ++++++++++++++++++++++++++++++++++++++++++++
>  include/netdev.h           |    1 +
>  4 files changed, 558 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/calxedaxgmac.c

Are there going to be any users for this driver?


Checkpatch says:

WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
#461: FILE: drivers/net/calxedaxgmac.c:317:
+} __attribute__((aligned(32)));

Is there any special reason not to change this?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No, I'm not going to explain it. If you  can't  figure  it  out,  you
didn't want to know anyway... :-)
                   - Larry Wall in <1991Aug7.180856.2854 at netlabs.com>