[U-Boot] [PATCH v4 1/5] arm, davinci: move davinci_rtc struct to hardware.h

Christian Riesch christian.riesch at omicron.at
Wed Dec 21 14:54:54 CET 2011


Hello Heiko,

On Tue, Nov 29, 2011 at 1:33 PM, Heiko Schocher <hs at denx.de> wrote:
> move struct davinci_rtc to arch/arm/include/asm/arch-davinci/hardware.h
> and add RTC_KICK0R_WE, RTC_KICK1R_WE defines,
> so they are global useable.
>
> Signed-off-by: Heiko Schocher <hs at denx.de>
> Cc: Sandeep Paulraj <s-paulraj at ti.com>

[...]

> diff --git a/arch/arm/include/asm/arch-davinci/hardware.h b/arch/arm/include/asm/arch-davinci/hardware.h
> index 06819a6..dd89e84 100644
> --- a/arch/arm/include/asm/arch-davinci/hardware.h
> +++ b/arch/arm/include/asm/arch-davinci/hardware.h

[..]

> +#define RTC_KICK0R_WE  0x130be783
> +#define RTC_KICK1R_WE  0xe0f1a495

Is there any reason why you changed the byte order (it's 0x83e70b13
and 0x95a4f1e0 in the manual) and then use out_be32() in
board/enbw/enbw_cmc/enbw_cmc.c on a little endian machine?

Thanks, Christian


More information about the U-Boot mailing list