[U-Boot] [PATCH 3/3] ARM:AM33XX: Add SPL support for AM335X EVM

[Tom Rini]

On Wed, Dec 21, 2011 at 6:03 AM, Chandan Nath <chandan.nath at ti.com> wrote:
> This patch is added to support SPL feature on AM335X
> platform. In this patch, MMC1 is configured as boot
> device for SPL and support for other devices will be
> added in the next patch series.
[snip]
> +#ifdef CONFIG_SPL_BUILD
> +u32 am33xx_boot_device = BOOT_DEVICE_MMC1;

Please see the Overo SPL thread where Wolfgang mentions the right way
to init this to 0 and have it be in the data section, followed by me
saying I'd see if <linux/compiler.h> had a shortcut.

> +u32 omap_boot_mode(void)
> +{

Something I wanted to see, but hadn't had a chance to look into was if
we could use the OMAP4/5 code for boot_mode as well, can you please
check?

[snip]
> -void s_init(u32 in_ddr)
> +void s_init(void)

Not that it's a huge deal but you didn't update lowlevel_init.S to not
pass in a param when calling s_init.

> diff --git a/arch/arm/include/asm/arch-am33xx/common_def.h b/arch/arm/include/asm/arch-am33xx/common_def.h
> new file mode 100644
> index 0000000..767932d
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-am33xx/common_def.h

Stuff either belongs in arch-am33xx/sys_proto.h or we need to re-think
where we're going with the pinmux code.  I know things will get more
complicated once we add i2c and can detect board revs and all of that.

-- 
Tom