[U-Boot] [PATCH 3/3] ARM:AM33XX: Add SPL support for AM335X EVM

[Tom Rini]

On Wed, Dec 21, 2011 at 8:55 AM, Aneesh V <aneesh at ti.com> wrote:
> On Wednesday 21 December 2011 09:16 PM, Tom Rini wrote:
>>
>> On Wed, Dec 21, 2011 at 6:03 AM, Chandan Nath<chandan.nath at ti.com>  wrote:
>>>
>>> This patch is added to support SPL feature on AM335X
>>> platform. In this patch, MMC1 is configured as boot
>>> device for SPL and support for other devices will be
>>> added in the next patch series.
>>
>> [snip]
>>>
>>> +#ifdef CONFIG_SPL_BUILD
>>> +u32 am33xx_boot_device = BOOT_DEVICE_MMC1;
>>
>>
>> Please see the Overo SPL thread where Wolfgang mentions the right way
>> to init this to 0 and have it be in the data section, followed by me
>> saying I'd see if<linux/compiler.h>  had a shortcut.
>
> But here looks like he doesn't intend to initialize it to 0?

I intended to before going "oh, that's right, it ends up in the BSS
not the data section, lemme set it to a value".

>>> +u32 omap_boot_mode(void)
>>> +{
>>
>>
>> Something I wanted to see, but hadn't had a chance to look into was if
>> we could use the OMAP4/5 code for boot_mode as well, can you please
>> check?
>>
>
> OMAP4/5 code parses ROM code structures (using a pointer passed by ROM
> code). If those structures and their layout are exactly same in AM33XX,
> it may work, otherwise it won't.

Yes, I think we share enough ROM code that it should work.  We're
using the OMAP4/5 code for boot device already (and it works for a
number of modes, we just don't have all the supporting code in
submittable state).

-- 
Tom