[U-Boot] [PATCH] USB: add CONFIG_USB_INIT to autoinitialize USB before main_loop

Igor Grinberg grinberg at compulab.co.il
Thu Dec 22 09:17:06 CET 2011


Hi Wolfgang,

On 12/22/11 10:06, Wolfgang Denk wrote:
> Dear Allen Martin,
> 
> In message <1324515956-1642-1-git-send-email-amartin at nvidia.com> you wrote:
>> This allows systems to pause autoboot with USB keyboard.  Tested on
>> tegra2 seaboard.
>>
>> Signed-off-by: Allen Martin <amartin at nvidia.com>
>> ---
>>  README               |    5 +++++
>>  arch/arm/lib/board.c |    9 +++++++++
>>  2 files changed, 14 insertions(+), 0 deletions(-)
> 
> This modification is in no way ARM specific, so if we accept it, it
> must be applied to all supported architectures.
> 
> Where exacly is this feature nneded?  You don;t enable it in any of
> the board configurations...
> 
> Also, should we then not auto-enable this if CONFIG_USB_KEYBOARD is
> set?

Right, IMHO, there is no need for a new config option -
just make the USB init depend on CONFIG_USB_KEYBOARD.


-- 
Regards,
Igor.


More information about the U-Boot mailing list