[U-Boot] [PATCH 3/3] post/lib_powerpc/multi.c: fix stack overflow error

Wolfgang Denk wd at denx.de
Fri Dec 23 20:08:14 CET 2011


Dear Wolfgang Denk,

In message <1324639752-26856-3-git-send-email-wd at denx.de> you wrote:
> The code and comment disagreed: the comment claimed that r6...r31
> were copied, and consequently the arrays for "src" and "dst" were
> declared with 26 entries, but the actual code ("lmw r5,0(r3)" and
> "stmw r5,0(r4)") copied _27_ words (r5 through r31), which resulted
> in false "POST cpu Error at multi test" messages.
> 
> Fix the comment and the array sizes.
> 
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> Cc: Anatolij Gustschin <agust at denx.de>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Kumar Gala <galak at kernel.crashing.org>
> Cc: Kim Phillips <kim.phillips at freescale.com>
> Cc: Andy Fleming <afleming at gmail.com>
> ---
>  post/lib_powerpc/multi.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Love is an ideal thing, marriage a real thing; a  confusion  of  the
real with the ideal never goes unpunished."                  - Goethe


More information about the U-Boot mailing list