[U-Boot] [PATCH v3] i.mx: i.mx6q: add the initial support for i.mx6q Sabre Lite board

[Stefano Babic]

On 26/12/2011 08:34, Dirk Behme wrote:
> From: Jason Liu <jason.hui at linaro.org>
> 
> Add the initial support for Freescale i.MX6Q Sabre Lite board
> 

Hi Dirk,

> 
> Index: freescale-u-boot-imx.git/MAINTAINERS
> ===================================================================
> --- freescale-u-boot-imx.git.orig/MAINTAINERS
> +++ freescale-u-boot-imx.git/MAINTAINERS
> @@ -579,6 +579,7 @@ Jason Liu <r64343 at freescale.com>
>  	mx53evk         i.MX53
>  	mx53loco        i.MX53
>  	mx6qarm2	i.MX6Q
> +	mx6qsabrelite   i.MX6Q

Can you confirm that Jason is the maintainer of the board ?

> +
> +#ifdef CONFIG_FSL_ESDHC
> +struct fsl_esdhc_cfg usdhc_cfg[2] = {
> +       {USDHC3_BASE_ADDR, 1},
> +       {USDHC4_BASE_ADDR, 1},
> +};
> +
> +int board_mmc_getcd(u8 *cd, struct mmc *mmc)
> +{
> +       struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
> +
> +       if (cfg->esdhc_base == USDHC3_BASE_ADDR) {
> +               gpio_direction_input(192); /*GPIO7_0*/
> +               *cd = gpio_get_value(192);
> +       } else {
> +               gpio_direction_input(38); /*GPIO2_6*/
> +               *cd = gpio_get_value(38);
> +       }
> +
> +       return 0;
> +}

I have not an evident comment with this code, but there are pending
patches to change this behavior:

http://patchwork.ozlabs.org/patch/132398/

The patches already updates other i.MX boards. If, as I presume, this
patches goes soon in mainline, board_mmc_getcd() must be updated to be
adjusted for the new API. I will wait a while before merging your patch
to check the status of the mmc patchset.

> @@ -0,0 +1,67 @@
> +U-Boot for the Freescale i.MX6q SabreLite board
> +
> +This file contains information for the port of U-Boot to the Freescale
> +i.MX6q SabreLite board.
> +
> +1. Boot source, boot from SD card
> +---------------------------------
> +
> +The recent mainline U-Boot for the Freescale i.MX6q SabreLite board supports
> +boot from SD card only. However, by default, the early version of SabreLite
> +boards boot from the SPI NOR flash. These boards need to be reflashed with
> +a small SD card loader to support boot from SD card. This small SD card loader
> +will be flashed into the SPI NOR. The board will still boot from SPI NOR, but
> +the loader will in turn request the BootROM to load the U-Boot from SD card.
> +At the moment of writing, please check with Freescale on the availablity of
> +this small SD loader binary.

Ok, fine. For my information only, is there a revision version to be
checked if the board needs this small loader ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================