[U-Boot] [PATCH v3] i.mx: i.mx6q: add the initial support for i.mx6q Sabre Lite board

[Liu Hui-R64343]

>-----Original Message-----
>From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
>On Behalf Of Dirk Behme
>Sent: Thursday, December 29, 2011 3:10 PM
>To: Stefano Babic; Jason Liu
>Cc: u-boot at lists.denx.de; Dirk Behme
>Subject: Re: [U-Boot] [PATCH v3] i.mx: i.mx6q: add the initial support for i.mx6q
>Sabre Lite board
>
>On 28.12.2011 13:32, Stefano Babic wrote:
>> On 26/12/2011 08:34, Dirk Behme wrote:
>>> From: Jason Liu<jason.hui at linaro.org>
>>>
>>> Add the initial support for Freescale i.MX6Q Sabre Lite board
>>>
>>
>> Hi Dirk,
>>
>>>
>>> Index: freescale-u-boot-imx.git/MAINTAINERS
>>>
>=================================================================
>==
>>> --- freescale-u-boot-imx.git.orig/MAINTAINERS
>>> +++ freescale-u-boot-imx.git/MAINTAINERS
>>> @@ -579,6 +579,7 @@ Jason Liu<r64343 at freescale.com>
>>>   	mx53evk         i.MX53
>>>   	mx53loco        i.MX53
>>>   	mx6qarm2	i.MX6Q
>>> +	mx6qsabrelite   i.MX6Q
>>
>> Can you confirm that Jason is the maintainer of the board ?
>
>Yes, I think so, it shouldn't have changed since v2
>
>http://lists.denx.de/pipermail/u-boot/2011-December/113142.html
>
>Jason?

Yes. And please change the tag with me to signed-off since I contribute the patch. Thanks,

>
>>> +
>>> +#ifdef CONFIG_FSL_ESDHC
>>> +struct fsl_esdhc_cfg usdhc_cfg[2] = {
>>> +       {USDHC3_BASE_ADDR, 1},
>>> +       {USDHC4_BASE_ADDR, 1},
>>> +};
>>> +
>>> +int board_mmc_getcd(u8 *cd, struct mmc *mmc) {
>>> +       struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg
>>> +*)mmc->priv;
>>> +
>>> +       if (cfg->esdhc_base == USDHC3_BASE_ADDR) {
>>> +               gpio_direction_input(192); /*GPIO7_0*/
>>> +               *cd = gpio_get_value(192);
>>> +       } else {
>>> +               gpio_direction_input(38); /*GPIO2_6*/
>>> +               *cd = gpio_get_value(38);
>>> +       }
>>> +
>>> +       return 0;
>>> +}
>>
>> I have not an evident comment with this code, but there are pending
>> patches to change this behavior:
>>
>> http://patchwork.ozlabs.org/patch/132398/
>>
>> The patches already updates other i.MX boards. If, as I presume, this
>> patches goes soon in mainline, board_mmc_getcd() must be updated to be
>> adjusted for the new API. I will wait a while before merging your
>> patch to check the status of the mmc patchset.
>
>Ok, good to know. Thanks!
>
>Let us know if you want us to update this patch against
>
>http://patchwork.ozlabs.org/patch/132398/

Yes, after the new MMC CD patch goes mainline, there will be a new version to update with it.

>
>>> @@ -0,0 +1,67 @@
>>> +U-Boot for the Freescale i.MX6q SabreLite board
>>> +
>>> +This file contains information for the port of U-Boot to the
>>> +Freescale i.MX6q SabreLite board.
>>> +
>>> +1. Boot source, boot from SD card
>>> +---------------------------------
>>> +
>>> +The recent mainline U-Boot for the Freescale i.MX6q SabreLite board
>>> +supports boot from SD card only. However, by default, the early
>>> +version of SabreLite boards boot from the SPI NOR flash. These
>>> +boards need to be reflashed with a small SD card loader to support
>>> +boot from SD card. This small SD card loader will be flashed into
>>> +the SPI NOR. The board will still boot from SPI NOR, but the loader will in
>turn request the BootROM to load the U-Boot from SD card.
>>> +At the moment of writing, please check with Freescale on the
>>> +availablity of this small SD loader binary.
>>
>> Ok, fine. For my information only, is there a revision version to be
>> checked if the board needs this small loader ?
>
>Good question ;) There is some discussion if it is possible to make a new version
>of the board which is configurable to SD boot by HW. But there seem to be
>some layout issues. So atm I would answer your question with 'no'.
+1

Happy New Year!
>
>Best regards
>
>Dirk
>
>_______________________________________________
>U-Boot mailing list
>U-Boot at lists.denx.de
>http://lists.denx.de/mailman/listinfo/u-boot