[U-Boot] [PATCH] disk/part.c: fix potential stack overflow bug

Lei Wen leiwen at marvell.com
Tue Feb 15 09:56:40 CET 2011


If the param pass to get_dev is not the one defined in the block_drvr,
it could make uboot becomes unstable, for it would continue run after
search complete the block_drvr table.

Signed-off-by: Lei Wen <leiwen at marvell.com>
---
 disk/part.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/disk/part.c b/disk/part.c
index 13723f2..f07a17f 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -84,7 +84,7 @@ block_dev_desc_t *get_dev(char* ifname, int dev)
 #ifdef CONFIG_NEEDS_MANUAL_RELOC
 	name += gd->reloc_off;
 #endif
-	while (name) {
+	while (drvr->name) {
 		name = drvr->name;
 		reloc_get_dev = drvr->get_dev;
 #ifdef CONFIG_NEEDS_MANUAL_RELOC
-- 
1.7.0.4



More information about the U-Boot mailing list