[U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again.

[Reinhard Meyer]

Dear Uli Raich,
> This version has been tested on an
> armputer-vmax board, which is similar to the at91sam9263ek
> but not on the at91sam9263ek board itself.
> A new configuration "armputer-vmax_config" has been added. This configuration
> has been tested on the hardware and is known to work. Further hardware tests
> for individual options are needed. The LCD screen was not tested.

Sorry, this has to get a full NAK.

1. Please never hijack someone's thread! Your patch has nothing to do with
someone's PATCH 18/18.

2. You are undoing all rework efforts with this patch!
The rework was, amongst others, to get rid of all AT91_*, AT91<SoC>_*, AVR*
macros and unify them into ATMEL_* macros. And by that also remove the twofold
re-wrapping of those defines.

> diff --git a/Makefile b/Makefile
> index 6133160..0c653fa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -827,7 +827,6 @@ at91sam9263ek_norflash_config \
>   at91sam9263ek_norflash_boot_config \
>   at91sam9263ek_nandflash_config \
>   at91sam9263ek_dataflash_config \
> -at91sam9263ek_dataflash_cs0_config \
>   at91sam9263ek_config	:	unconfig

If, all entries have to be moved to boards.cfg

> -	at91_pmc_t *pmc = (at91_pmc_t *) ATMEL_BASE_PMC;
> +	at91_pmc_t *pmc = (at91_pmc_t *) AT91_PMC_BASE;

ATMEL_BASE_*, ATMEL_ID_* are the new names that are the same names for all ATMEL SoCs,
although they might hold different numerical values.

> -	at91_pit_t *pit = (at91_pit_t *) ATMEL_BASE_PIT;
> +	at91_pit_t *pit = (at91_pit_t *) AT91_PIT_BASE;

and so on...

> -	at91_pmc_t *pmc = (at91_pmc_t *) ATMEL_BASE_PMC;
> -	at91_pit_t *pit = (at91_pit_t *) ATMEL_BASE_PIT;
> +        at91_pmc_t *pmc = (at91_pmc_t *) AT91_PMC_BASE;
> +	at91_pit_t *pit = (at91_pit_t *) AT91_PIT_BASE;

You even re-add white-space errors..

...

> -	atmel_usart3_t *usart = (atmel_usart3_t *)CONFIG_USART_BASE;
> +	atmel_usart3_t *usart = (atmel_usart3_t*)AT91_DBGU_BASE;

It seems you have not understood the concept of "CONFIG_" macros.
They are to allow the designer to use different USARTs, not
explicitly only the one in the debug unit...

3. And, please, run your patches through checkpatch.pl

Best Regards,
Reinhard