[U-Boot] [PATCH v2 2/9] make the hwconfig buffer deeper

[Wolfgang Denk]

Dear Kumar Gala,

In message <740DF509-6661-4611-BE1B-BBB629012697 at kernel.crashing.org> you wrote:
> 
> >> Making a buffer in a function's stack and make use of it out of the
> >> scope, that's the buggy code I am referring. 
> > 
> > That is bad indeed, and needs to be fixed.
>
> Where is that happening?

__hwconfig() calls hwconfig_parse() an passes a local stack buffer
(buf) as argument; hwconfig_parse() returns a pointer into this
buffer; then __hwconfig() returns the return value from
hwconfig_parse() - but here the local stack buffer gots out of scope.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Make it right before you make it faster.