[U-Boot] [PATCH v2 2/9] make the hwconfig buffer deeper

York Sun yorksun at freescale.com
Mon Jan 10 19:39:31 CET 2011


On Sun, 2011-01-09 at 15:00 -0600, Kumar Gala wrote:
> On Jan 7, 2011, at 5:23 PM, Kumar Gala wrote:
> 
> > 
> > On Jan 7, 2011, at 11:52 AM, Wolfgang Denk wrote:
> > 
> >> Dear York Sun,
> >> 
> >> In message <1294418957.8466.8.camel at oslab-l1> you wrote:
> >>> 
> >>> fsl_ddr:ctlr_intlv=cacheline,bank_intlv=cs0_cs1_cs2_cs3,ecc=off,addr_hash=false
> >>> 
> >>> With the buffer size 128, the sub function gets
> >>> "ctlr_intlv=cacheline,bank_intlv=cs0_". It is not because the buffer is
> >>> not enough, but the stack has been trashed. I have debug log if you need
> >>> it.
> >> 
> >> This is yet another problem, then.
> > 
> > So I figured the problem out and need to rework the hwconfig API to fix it.
> > 
> > We need some new versions of the APIs that take a buffer for use early before boot.  
> 
> I've posted:
> 
> http://patchwork.ozlabs.org/patch/78045/
> http://patchwork.ozlabs.org/patch/78046/
> 
> Which should resolve the hwconfig issue and not require the patch to bump the size up.

I have confirmed your patches. I will drop this patch and resubmit the
rest.

York





More information about the U-Boot mailing list