[U-Boot] [PATCH v5 0/8] those series patches for add ben nanonote board

[Shinya Kuribayashi]

Thanks for keeping on working on jz4740 patchset.

On 01/10/2011 01:18 AM, Xiangfu Liu wrote:
> Hi Wolfgang
>   those patches are for add xburst jz4740 and Ben NanoNote(named qi_lb60) to U-Boot
> 
> some info about xburst jz4740:
>   the xburst jz4740 is recently added to linux 2.6.36
>   and it's support the device Ben NanoNote out of box,

  :
  :

Very useful comments, so such info should also be put into patch
description of the relevant changes; Jz4740 SoC overview and about USB
boot, respectively.

> ====
> FIXED in [PATCH v3]
>   1. describe what Jz4740 SoC
>   2. remove the ENDIANNESS in config.mk
>   3. don't breaks the 80-charcter-wide rule
>   4. get rid of #if 0
>   5. use proper I/O accessors to access registers.
>   6. remove C++ comments, cleanup code style.
> 
> FIXED in [PATCH v4]
>   1. add Entry to MAINTAINERS and boards.cfg
>   2. add ben nanonote(qi_lb60) to Makefile
>   3. tested with CROSS_COMPILE=mips_4KCle- ./MAKEALL mips_el
> 
> FIXED in [PATCH v5]
>   1. remove nand_spl/nand_boot_jz4740.c
>   2. some cleanup

Having a quick glance, v5 still has issues (e.g. it gets split into
8 patches in an improper way).  I'll have a closer look later.

By the way, I've uploaded xl/jz4740-ben-nanonote-v5 branch (and older
v2/v3/v4 branches as well) to make reviews easier for involved people.