[U-Boot] [PATCH v5 1/8] those files are jz4740 base files

[Wolfgang Denk]

Dear Xiangfu Liu,

In message <1294589925-32639-2-git-send-email-xiangfu at openmobilefree.net> you wrote:
> Signed-off-by: Xiangfu Liu <xiangfu at openmobilefree.net>
> Acked-by: Daniel <zpxu at ingenic.cn>
> Acked-by: ChangWei Jia <cwjia at ingenic.cn>
> 
> ---
>  arch/mips/cpu/xburst/Makefile    |   50 +++
>  arch/mips/cpu/xburst/config.mk   |   33 ++
...

There is no description of the changes in this version of the patch.
The notes in the introductory message are _not_ sufficient, please see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
(bullet 2)

...
> +	while (1) {
> +		cache_op(Hit_Writeback_Inv_D, addr);
> +		cache_op(Hit_Invalidate_I, addr);

We do not allow CamelCase identifiers in U-Boot.  Please fix globally.


> +	while ( !__rtc_write_ready())
> +		;

No space after the paren; please fix globally.

...
> +int serial_init (void)
> +{
> +#if !defined(CONFIG_NAND_U_BOOT) || defined(CONFIG_NAND_SPL)
> +	volatile u8 *uart_fcr = (volatile u8 *)(CONFIG_SYS_UART_BASE + OFF_FCR);
> +	volatile u8 *uart_lcr = (volatile u8 *)(CONFIG_SYS_UART_BASE + OFF_LCR);
> +	volatile u8 *uart_ier = (volatile u8 *)(CONFIG_SYS_UART_BASE + OFF_IER);
> +	volatile u8 *uart_sircr = (volatile u8 *)(CONFIG_SYS_UART_BASE + OFF_SIRCR);

Please do not use base + offset notation.  Declare a proper C struct
instead.  Please fix globally.

> +	/* Disable port interrupts while changing hardware */
> +	*uart_ier = 0;

And use proper I/O accessors to access device registers. Please fix
globally.

...
> +static ulong timestamp;
> +static ulong lastdec;

As already has been pointed out several times before: this will not
work because BSS cannot be accessed before relocation.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We don't have to protect the environment -- the Second Coming is  at
hand."                                                   - James Watt