[U-Boot] [PATCH 23/28] Blackfin: bf506f-ezkit: new board port

[Wolfgang Denk]

Dear Mike Frysinger,

In message <1293425300-27644-24-git-send-email-vapier at gentoo.org> you wrote:
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> ---
>  board/bf506f-ezkit/Makefile       |   54 +++++++++++++++++++
>  board/bf506f-ezkit/bf506f-ezkit.c |   27 +++++++++
>  boards.cfg                        |    1 +
>  include/configs/bf506f-ezkit.h    |  106 +++++++++++++++++++++++++++++++++++++
>  4 files changed, 188 insertions(+), 0 deletions(-)
>  create mode 100644 board/bf506f-ezkit/Makefile
>  create mode 100644 board/bf506f-ezkit/bf506f-ezkit.c
>  create mode 100644 include/configs/bf506f-ezkit.h

Entry to MAINTAINERS missing.

...
> +#define CONFIG_EBIU_SDGCTL_VAL	(SCTLE | CL_3 | PASR_ALL | TRAS_6 | TRP_3 | TRCD_3 | TWR_2 | PSS)
> +
> +#define CONFIG_EBIU_AMGCTL_VAL	(AMCKEN | AMBEN_ALL)
> +#define CONFIG_EBIU_AMBCTL0_VAL	(B1WAT_15 | B1RAT_15 | B1HT_3 | B1RDYPOL | B0WAT_15 | B0RAT_15 | B0HT_3 | B0RDYPOL)
> +#define CONFIG_EBIU_AMBCTL1_VAL	(B3WAT_15 | B3RAT_15 | B3HT_3 | B3RDYPOL | B2WAT_15 | B2RAT_15 | B2HT_3 | B2RDYPOL)

Lines too long.

> +#define CONFIG_SYS_MONITOR_BASE (L1_DATA_A_SRAM_END)

> +#define CONFIG_SYS_MONITOR_LEN	(4 * 1024)
> +#define CONFIG_SYS_MALLOC_LEN	(4 * 1024)

Sure that 4 KiB is sufficient for these two?

....
> +#undef CONFIG_BOOTM_LINUX
> +
> +
> +#endif

Only one blank line, please.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only way to learn a new programming language is by  writing  pro-
grams in it.                                        - Brian Kernighan