[U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

Sergei Shtylyov sshtylyov at mvista.com
Wed Jan 12 14:10:42 CET 2011


On 11.01.2011 3:31, Mike Frysinger wrote:

>>> it isnt a problem to have the parens, and it keeps things sane if someone
>>> does something like:
>>> #define CONFIG_SYS_BD_INFO_ADDR   SOME_DEFINE + 0x1000

>> This would be a violation of basic rules of defensive coding.

>> Please drop these parens.

> i dont see how these two statements are compatible.  defensive coding would
> mean i keep the parens.

    I think Wolfgang meant that defining a macro without parens would be a 
violation -- which should be fixed, not worked around.

> -mike

WBR, Sergei


More information about the U-Boot mailing list