[U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init

seedshope bocui107 at gmail.com
Sat Jan 22 20:23:44 CET 2011


On 01/22/2011 03:31 PM, Albert ARIBAUD wrote:
> Hi seedshope,
>
> Le 22/01/2011 02:56, seedshope a écrit :
>
>>>> My patch is ok, I just two tabs in my e-mail, But I sent the mail,
>>>> It is change.
>>> Do you send the patch through git format-patch and git send-email?
>
>> Yes, I use the git format-patch and git send-email
>
>>> Many e-mail softwares have weird issues when posting git patches,
>>> which is why git has its own tools for sending patches via e-mail.
>
>> ok
>
> Since you're using git format-patch and git send-email, then your 
> original change is not correctly aligned. I suggest you check your 
> code editor's settings on indentation and use of tabulations, notably 
> the "tab size": tabs should align on 8-space multiples; also check 
> that your editor uses a fixed font -- you never know.
Hi Amicalement

I check my patch 6 on the 
http://news.gmane.org/gmane.comp.boot-loaders.u-boot, It look fine.
I have a bit despondent. Why do you think it has a format problem.

Thanks
seedshope
>
> Amicalement,



More information about the U-Boot mailing list