[U-Boot] [PATCH] Top config.mk: add include/config.mk

[Joakim Tjernlund]

Wolfgang Denk <wd at denx.de> wrote on 2011/01/23 20:35:48:
>
> Dear Joakim Tjernlund,
>
> In message <OF749BBC82.7AA2F037-ONC1257821.0069EDA0-C1257821.0069FC15 at transmode.se> you wrote:
> >
> > >
> > > Seems to that the top level config.mk should include
> > > the auto generated include/config.mk so that all Makefile's
> > > pickup those definitions.
> > >
> > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> > > ---
> > >  config.mk |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/config.mk b/config.mk
> > > index bcda776..c7534fb 100644
> > > --- a/config.mk
> > > +++ b/config.mk
> > > @@ -117,6 +117,7 @@ RANLIB   = $(CROSS_COMPILE)RANLIB
> > >
> > >  # Load generated board configuration
> > >  sinclude $(OBJTREE)/include/autoconf.mk
> > > +sinclude $(OBJTREE)/include/config.mk
> > >
> > >  # Some architecture config.mk files need to know what CPUDIR is set to,
> > >  # so calculate CPUDIR before including ARCH/SOC/CPU config.mk files.
> > > --
> > > 1.7.3.4
> >
> > Ping?
>
> What is the exact problem you are trying to fix?  Do you have a test
> case?

Example from my board/config.mk, I have:
ifeq ($(SUBBOARD),cu)
  LUMENTIS_CPPFLAGS=-DCONFIG_IDENT_STRING=\"\\nCBX-0001A:cuboot02a:p1a:99\"
else
  LUMENTIS_CPPFLAGS=-Dinclude/config.mk=\"\\nCBX-0001A:tuboot02a:p1a:99\"
endif

My generated include/config.mk has
 SUBBOARD  = cu

SUBBOARD will not be defined in all Makefiles unless I
add the above patch, in this case arch/powerpc/cpu/mpc83xx/Makefile
will not see it.

 Jocke