[U-Boot] [PATCH] Top config.mk: add include/config.mk

[Wolfgang Denk]

Dear Joakim Tjernlund,

In message <OF0949C72E.59C831F7-ONC1257821.006EE01D-C1257821.006FFF7C at transmode.se> you wrote:
>
> > What is the exact problem you are trying to fix?  Do you have a test
> > case?
> 
> Example from my board/config.mk, I have:
> ifeq ($(SUBBOARD),cu)
>   LUMENTIS_CPPFLAGS=-DCONFIG_IDENT_STRING=\"\\nCBX-0001A:cuboot02a:p1a:99\"
> else
>   LUMENTIS_CPPFLAGS=-Dinclude/config.mk=\"\\nCBX-0001A:tuboot02a:p1a:99\"
> endif
> 
> My generated include/config.mk has
>  SUBBOARD  = cu
> 
> SUBBOARD will not be defined in all Makefiles unless I
> add the above patch, in this case arch/powerpc/cpu/mpc83xx/Makefile
> will not see it.

You should move all this config stuff into your board config file and
get rid of this board/config.mk alltogether.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many hardware guys does it take to change a light bulb? "Well the
diagnostics say it's fine buddy, so it's a software problem."