[U-Boot] [PATCH] Top config.mk: add include/config.mk

Joakim Tjernlund joakim.tjernlund at transmode.se
Mon Jan 24 00:27:21 CET 2011


Wolfgang Denk <wd at denx.de> wrote on 2011/01/23 23:50:03:
> Dear Joakim Tjernlund,
>
> In message <OF0949C72E.59C831F7-ONC1257821.006EE01D-C1257821.006FFF7C at transmode.se> you wrote:
> >
> > > What is the exact problem you are trying to fix?  Do you have a test
> > > case?
> >
> > Example from my board/config.mk, I have:
> > ifeq ($(SUBBOARD),cu)
> >   LUMENTIS_CPPFLAGS=-DCONFIG_IDENT_STRING=\"\\nCBX-0001A:cuboot02a:p1a:99\"
> > else
> >   LUMENTIS_CPPFLAGS=-Dinclude/config.mk=\"\\nCBX-0001A:tuboot02a:p1a:99\"
> > endif
> >
> > My generated include/config.mk has
> >  SUBBOARD  = cu
> >
> > SUBBOARD will not be defined in all Makefiles unless I
> > add the above patch, in this case arch/powerpc/cpu/mpc83xx/Makefile
> > will not see it.
>
> You should move all this config stuff into your board config file and
> get rid of this board/config.mk alltogether.

Yes I can, in fact I stated to do this. Then it occurred to
me that stuff defined in include/config.mk should be globally
available, hence this patch.

 Jocke



More information about the U-Boot mailing list