[U-Boot] [PATCH v2 2/3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules

Reinhard Meyer u-boot at emk-elektronik.de
Thu Jan 27 07:13:21 CET 2011


Dear Ryan Mallon,
> Did you have any additional changes you want made for the
> Snapper9260/9G20 patches other than adding a MAINTAINERS entry and
> rolling the boards.cfg change into a single patch?

Yes, the following things should be changed:

1. sort the boards.cfg entry to the right place.
See top of boards.cfg for the rules.
bluewater would be between atmel and emk ;)

2. #define SOMETHING 1. The "1" is depreciated if it serves no numeric
meaning. Remove them in your board config.
(Make sure the white space goes as well)

3. SZ_* macros are depreciated. Use numeric values. (256 << 20) is
preferred to denote 256MiB.

Sorry I had no time to look deeper into details, but it looked good otherwise.

Can you confirm that the code builds and runs after the changes?
I can't verify the "runs" part...

Best Regards,
Reinhard


More information about the U-Boot mailing list