[U-Boot] [PATCH0/6] patchset to support TPL and P1021MDS board

Scott Wood scottwood at freescale.com
Mon Jan 31 21:13:32 CET 2011


On Mon, 31 Jan 2011 20:39:51 +0100
Wolfgang Denk <wd at denx.de> wrote:

> Dear Haiying.Wang at freescale.com,
> 
> In message <1296499317-26616-1-git-send-email-Haiying.Wang at freescale.com> you wrote:
> > This patchset adds support for TPL(Tertiary Program Loader) and P1021MDS board.
> > It is a rework of patchset at
> > http://lists.denx.de/pipermail/u-boot/2010-December/082881.html, 
> > addresses the comments from the list and is based on the top of the tree. 
> > It needs to be applied after patch 
> > http://lists.denx.de/pipermail/u-boot/2011-January/086346.html and patch 
> > http://lists.denx.de/pipermail/u-boot/2011-January/086524.html
> 
> I think these patches are incorrectly split.

I think the intent was to split the arch-neutral stuff from the 85xx
stuff from the board stuff -- you'd rather they be all bunched together?

> [PATCH 1/6] Introduce the Tertiary Program loader
> 
> 	This patch adds stuff to the Makefile, which would result in
> 	errors if used, as the referenced directories don't exist yet.

Lots of patches add features, disabled by default, that require CPU or
board code to provide things, that would cause errors if the feature
were enabled on a board otherwise.

I don't think it's even possible to add an empty directory with git.

> [PATCH 2/6] powerpc/85xx: add TPL support
> 
> 	This patch creates unused files, like
> 	arch/powerpc/cpu/mpc85xx/u-boot-tpl.lds

It gets used in later in the patchset, when a board with tpl is added.

-Scott



More information about the U-Boot mailing list