[U-Boot] [PATCH0/6] patchset to support TPL and P1021MDS board

[Wolfgang Denk]

Dear Scott Wood,

In message <20110131141332.5a4a297d at udp111988uds.am.freescale.net> you wrote:
>
> > I think these patches are incorrectly split.
> 
> I think the intent was to split the arch-neutral stuff from the 85xx
> stuff from the board stuff -- you'd rather they be all bunched together?

No, of course not all together.

> > 	This patch adds stuff to the Makefile, which would result in
> > 	errors if used, as the referenced directories don't exist yet.
> 
> Lots of patches add features, disabled by default, that require CPU or
> board code to provide things, that would cause errors if the feature
> were enabled on a board otherwise.

But here nothing is disabled. It's added to the top level Makefile.
It's dead code if unused, and causes errors if used.  WHy not add the
tpl target when you actually add the tpl code?

> I don't think it's even possible to add an empty directory with git.

True.  Butt that would not fix anythign, it would still not work.

> > [PATCH 2/6] powerpc/85xx: add TPL support
> > 
> > 	This patch creates unused files, like
> > 	arch/powerpc/cpu/mpc85xx/u-boot-tpl.lds
> 
> It gets used in later in the patchset, when a board with tpl is added.

Then this is where that file belongs to.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Eureka!                                                 -- Archimedes