[U-Boot] [PATCH 6/6] p1021mds: add QE and UEC support

[Kumar Gala]

On Jan 31, 2011, at 2:50 PM, Haiying Wang wrote:

> On Mon, 2011-01-31 at 21:11 +0100, Wolfgang Denk wrote:
>>> 
>>> +#ifdef CONFIG_P1021
>>> +	ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
>>> +
>>> +	/* QE9 and QE12 need to be set for enabling QE MII managment signals */
>>> +	setbits_be32(&gur->pmuxcr, MPC85xx_PMUXCR_QE9);
>>> +	setbits_be32(&gur->pmuxcr, MPC85xx_PMUXCR_QE12);
>>> +#endif
>> ...
>> 
>> Can we please avoid having board specific code in common files?
> I wish I could, but only P1021 has such pin mux problems.
> 
>> If this is really necessary, it shoud be a feature-specific #define,
>> not a board specific one.
> I don't know whether this *feature* will show up on other SoC. But if
> you insist, I can use CONFIG_QE_PIN_MUX.
> 
> Thanks.
> 
> Haiying

I think pin muxing is a board level decision so it seems like board code is the right place for it.

- k