[U-Boot] [PATCH V4 3/5] nand spl: add NAND Library to new SPL

[V, Aneesh]

Hi Simon, Scott,

On Wed, Jul 27, 2011 at 2:52 PM, Simon Schwarz
<simonschwarzcor at googlemail.com> wrote:
> Dear Scott Wood,
>
> On 07/26/2011 08:04 PM, Scott Wood wrote:
>> On Tue, 26 Jul 2011 14:09:16 +0200
>> Simon Schwarz<simonschwarzcor at googlemail.com>  wrote:
>>
>>> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
>>> index 8b598f6..cdc9a14 100644
>>> --- a/drivers/mtd/nand/Makefile
>>> +++ b/drivers/mtd/nand/Makefile
>>> @@ -26,12 +26,16 @@ include $(TOPDIR)/config.mk
>>>   LIB        := $(obj)libnand.o
>>>
>>>   ifdef CONFIG_CMD_NAND
>>> +ifdef CONFIG_SPL_BUILD
>>> +COBJS-y += nand_spl.o
>>> +else
>>>   COBJS-y += nand.o
>>>   COBJS-y += nand_base.o
>>>   COBJS-y += nand_bbt.o
>>> -COBJS-y += nand_ecc.o
>>>   COBJS-y += nand_ids.o
>>>   COBJS-y += nand_util.o
>>> +endif
>>> +COBJS-y += nand_ecc.o
>>
>> You're assuming all NAND SPLs will want nand_ecc -- this will not fit in
>> most current ones.
>
> True. I changed it to:
> ifdef CONFIG_SPL_BUILD
> COBJS-y += nand_spl.o
> ifdef CONFIG_OMAP34XX

-ffunction-sections, -fdata-sections and --gc-sections are enabled globally
for SPL. Source files are #ifdef'ed out in Makefile's for SPL primarily to
reduce build time.

I would suggest to enable the super set of all files needed for all SPL's
in these Makefile's and not clutter it with any more #ifdef's

best regards,
Aneesh