[U-Boot] [PATCH v6] unify version_string

Wolfgang Denk wd at denx.de
Thu Jul 28 17:23:27 CEST 2011


Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,

In message <1311013444-74984-1-git-send-email-andreas.devel at googlemail.com> you wrote:
> This patch removes the architecture specific implementation of
> version_string where possible. Some architectures use a special place
> and therefore we provide U_BOOT_VERSION_STRING definition and a common
> weak symbol version_string.
> 
> Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com>
> CC: Mike Frysinger <vapier at gentoo.org>
> CC: Peter Pan <pppeterpppan at gmail.com>
> Acked-by: Mike Frysinger <vapier at gentoo.org>
> ---
> changes since v1:
>  - remove (some) places of 'extern ... version_string' definition in favour of
>    include version.h
>  - use format-patch && send-email since some complained about base64 formated
>    mail content
> 
> changes since v2:
>  - add linker script solution for mpc512x powerpc devices
>    (never compiled)
> 
> changes since v3:
>  - use a common variable to join the parameters and leave the arch dependent
>    parts as is
> 
> changes since v4:
>  - address comments from mike
>    * do not use const char * const
>    * use weak symbol version_string, remove from architecture files
>    * remove trailing semicolon
> 
> changes since v5:
>   - remove RFC annotation
>   - add ACK-by Mike Freysinger
> 
>  arch/arm/lib/board.c              |    8 --------
>  arch/avr32/lib/board.c            |    4 ----
>  arch/blackfin/lib/board.c         |    3 ---
>  arch/m68k/cpu/mcf5227x/start.S    |    5 +----
>  arch/m68k/cpu/mcf523x/start.S     |    5 +----
>  arch/m68k/cpu/mcf52x2/start.S     |    5 +----
>  arch/m68k/cpu/mcf532x/start.S     |    5 +----
>  arch/m68k/cpu/mcf5445x/start.S    |    5 +----
>  arch/m68k/cpu/mcf547x_8x/start.S  |    5 +----
>  arch/microblaze/lib/board.c       |    3 ---
>  arch/mips/lib/board.c             |    4 ----
>  arch/nios2/cpu/start.S            |    9 +--------
>  arch/powerpc/cpu/74xx_7xx/start.S |    9 +--------
>  arch/powerpc/cpu/mpc512x/start.S  |   12 ++++--------
>  arch/powerpc/cpu/mpc5xx/start.S   |    9 +--------
>  arch/powerpc/cpu/mpc5xxx/start.S  |    9 +--------
>  arch/powerpc/cpu/mpc8220/start.S  |    9 +--------
>  arch/powerpc/cpu/mpc824x/start.S  |    9 +--------
>  arch/powerpc/cpu/mpc8260/start.S  |    9 +--------
>  arch/powerpc/cpu/mpc83xx/start.S  |   12 ++++--------
>  arch/powerpc/cpu/mpc85xx/start.S  |    9 +--------
>  arch/powerpc/cpu/mpc86xx/start.S  |    9 +--------
>  arch/powerpc/cpu/mpc8xx/start.S   |    9 +--------
>  arch/powerpc/cpu/mpc8xx/video.c   |    1 -
>  arch/powerpc/cpu/ppc4xx/start.S   |    9 +--------
>  arch/sh/lib/board.c               |    3 ---
>  arch/sparc/cpu/leon2/start.S      |    5 +----
>  arch/sparc/cpu/leon3/start.S      |    5 +----
>  arch/x86/lib/board.c              |    4 ----
>  common/cmd_version.c              |    3 ++-
>  common/main.c                     |    3 +--
>  drivers/video/cfb_console.c       |    2 +-
>  include/version.h                 |   11 +++++++++++
>  lib/display_options.c             |    3 +--
>  34 files changed, 43 insertions(+), 172 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
EMACS belongs in <sys/errno.h>: Editor too big!


More information about the U-Boot mailing list